Retired

Reason for Retirement: Please confirm if this is still a problem in the latest
version of Smart.

Please reopen this issue in the new bugtracker if it is still an issue.
New Bugtracker : http://bugs.launchpad.net/smart
further details:
https://blueprints.launchpad.net/smart/+spec/bug-reporting-migration.

Looks like it will demand a lot of work to implement the format proposed by
fundawang. The correct solution would be (using bogdano's example):

>>> m={"foo":"sape", "bar":"grimpa"}
>>> smart._("Some people call %(foo)s as %(bar)s") % m
u'Some people call sape as grimpa'

So it would need to create a dict mapping for each string that uses more than
one var. It's doable, but would require quite some work on rewriting a lot of
code, and rechecking all the translation files.

Anyone agree with fundawang's suggestion? Does it really brings any advantage
over the current way?

Fundawang,

Would you be interested in fixing this patch of should we close the issue?  It
has been 6 months since the last activity on the issue.

Dave

*cough* You are right of course

I reverted the last commit and grabbed a brown paperbag to wear it all day.

Thanks,
 Michael

2006/5/8, Michael Vogt at Labix Tracker <tracker@labix.org>:
>
> Michael Vogt <michael.vogt@ubuntu.com> added the comment:
>
> Thanks for your bugreport and your patch.
>
> I applied it to the svn trunk/ and it will be part of the next release.
>

This patch has been fully tested? Am I missing something about the
behavior of "%(name)s" format?

<smart.control.Control object at 0xb77b4aec>
>>> foo = "sapé"
>>> bar = "grimpa"
>>> smart._("Some people call %(foo)s as %(bar)s") % (foo, bar)
Traceback (most recent call last):
  File "<stdin>", line 1, in ?
TypeError: format requires a mapping

Thanks for your bugreport and your patch. 

I applied it to the svn trunk/ and it will be part of the next release.

Cheers,
 Michael

Patch against the issue

There might be some more places for the translators to reorder the parameters. 
So, including variable name should be as more as possible.